cweill / gotests

Automatically generate Go test boilerplate from your source code.
Apache License 2.0
4.92k stars 346 forks source link

return on wantErr bypass Subtests #169

Open arifmahmudrana opened 2 years ago

arifmahmudrana commented 2 years ago

Thanks for your contribution. When I am generating test if the function has error then we add a test for wantErr then adds Subtests. But there should be a return statement also and return if wantErr e.g

t.Run(tt.name, func(t *testing.T) {
    got, err := tt.p.Write(tt.args.record)
    if (err != nil) != tt.wantErr {
        t.Errorf("parquetWriter.Write() error = %v, wantErr %v", err, tt.wantErr)
        return
    }
        //////////////////// this return should be added//////////////////////////
    if tt.wantErr {
        return
    }
        //////////////////// this return should be added//////////////////////////

       // There is no point checking Subtests if I want error it may create wrong test result
    if got != tt.want {
        t.Errorf("parquetWriter.Write() = %v, want %v", got, tt.want)
    }
})