cweiske / phorkie

Self-hosted pastebin software written in PHP. Pastes are editable, forkable, may have multiple files and are stored in git repositories.
https://cweiske.de/phorkie.htm
GNU Affero General Public License v3.0
216 stars 23 forks source link

Added Markdown from jnovack.github.com/pear/Markdown #12

Closed jnovack closed 12 years ago

jnovack commented 12 years ago

Markdown was revamped by Filipe Dobreira (https://github.com/filp/Markdown) to be PHP 5.3.0 complaint with object-orientation goodness.

I had since:

I created my own github pear repository to host the PEAR repo, and installed it.

This now permits setup checking properly.

This branch is running at phorkie.ozmonet.com

cweiske commented 12 years ago

While this is a tempting idea, I'm also reluctant to not use the package from the official maintainer.

The main problem I have is that the future of your repository is uncertain, while I have higher hopes for the (current) maintainer - his code will always be up to date, at least until he decides to not maintain it anymore.

Please please try to get your changes merged. Discuss the issues with him and convince him that your version is better. Find a solution to keep BC.

Also run phpcs (PHP_CodeSniffer) on that code; your announced PEAR compliance still leaves 245 CS errors.

jnovack commented 12 years ago

To be fair, I said "more" PEAR compliance, I never said it was complete. ;)

I understand, I'm a nobody, but why not your repo then? You already have packages coming from there.

In this instance, I'm unsure of the official maintainer. The original maintainer michelf, is unwilling to update to Object-Orientated code because he wants to support PHP4 (doesn't make him a bad person). I have a pull request pending to filp which makes his repo a fork which may never be merged.

Don't make me run PHP_CodeSniffer on the phorkie classes. ;)

cweiske commented 12 years ago

Hello Justin,

I understand, I'm a nobody, but why not your repo then? You already have packages coming from there. Because I know about the burden of maintenance and won't do that. I rather have a small hack in my software and use a maintained package than forking it.

In this instance, I'm unsure of the official maintainer. The original maintainer michelf, is unwilling to update to Object-Orientated code because he wants to support PHP4 (doesn't make him a bad person). PHP 5.2 is EOL'd, and PHP4's EOL is long forgotten in the dawns of time. PHP4 compatiblity makes no sense anymore. But it's his decision.

Don't make me run PHP_CodeSniffer on the phorkie classes. ;) Do it. I did yesterday, and all that's left are "docblock missing" errors.

Regards/Mit freundlichen Grüßen Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

jnovack commented 12 years ago

Should I close and delete this branch? No point in leaving this out there while I attempt to resolve it with the maintainers.

cweiske commented 12 years ago

throw it away.