Bootstrap Compliance

[jnovack]

The following commits correct a number of issues with bootstrap compliance.

725267f - Uses correct tag for right-alignment and reduces font on sidebar to not be so in-your-face.

b077b2a - This commit hard-codes bootstrap into base.htm as a basic CSS. But more importantly, loads a custom css file last the user can tweak or redesign. (Or themes? 0.5?)

• Added bootstrap-responsive.css for correct fluid rendering.
• Added bootstrap js files.
• base.htm had its menu bar properly bootstrap'd for correct responsiveness (test the webpage at all widths from 320px to 1400+px.
• phorkie.css impliments the optional wide bootstrap css for screen widths over 1200px.

This is live at http://phorkie.ozmonet.com/

[cweiske]

No. Do not harcode the CSS path. I work offline many times in the train to and from work, so I cannot live with that at all. Maybe rename "css" to "bootstrapUrl" and default it to twitter.github.com/bootstrap/assets/, but I want to be able to change it. Also, https users may not be forgotten. Using http urls doesn't work for them.

[jnovack]

I still like the idea of having a separate CSS file, for personalization. Change a few colors, styles, what-have-you.

[cweiske]

I understand the feeling about depending on other hosts, and we should fix that. Iwould rather not use a submodule but include the bootstrap files we utilize directly in our repository.

The custom css file is fine.

[jnovack]

I would like to include font-awesome (http://fortawesome.github.com/Font-Awesome/) rather than the hundred of glyphicons. Font-Awesome scales better with size.

[cweiske]

I would like to include font-awesome Sure.

Regards/Mit freundlichen Grüßen Christian Weiske

-= Geeking around in the name of science since 1982 =-

[jnovack]

Squashed.

[cweiske]

Please remove your private changes to phorkie.css. I currently like the width.

And I know I'm picky, but could you have a separate commit for the bootstrap files? That way it's easier to follow, as the diff that changes phorkie itself is not so large.

Also, please write down the version of the bootstrap files that we're currently using. And add the minified versions of the bootstrap css and js files instead of the normal ones.

[jnovack]

What about adding it to widescreen.css and silently including it in the css directory but not in the configuration. You know, for people that have larger monitors than 1024x768? :p

I do not see minified css files and the only minified js file is the main one, which I will do.

[cweiske]

It kinda seems to me as if you didn't even test it.

1. When you switch E_NOTICE on in your php.ini's error_reporting setting, you'll see a bootstrap variable warning. That one does not exist anymore.
2. jQuery cannot be added at the end of the html because at least "new" and "edit" register a document.ready hook that fails now because jQuery is not available.
3. I don't like that the navbar spans across all the screen while the content is centered.

[jnovack]

Thanks for pointing that out. My log rotated on me and thus I was tailing nothing. Which is why I didn't have errors. #fail

[cweiske]

I've merged most of the commits except "Convert Login/Logout Links to Buttons".

Why do you change login and logout links in the sidebar to

s, while normal tags suffice?

If it's really because you like the button-style look (I don't in the menu), then you can just apply the "btn" class to the a tag:

Button styles can be applied to anything with the .btn class applied. However, typically you'll want to apply these to only and elements for the best rendering.

I don't see any reason for them to be buttons, though.

I kept it consistent with other things that "send to a page". "Head" sends you to a page, that's a button, etc.