search

cweiske / phorkie

Self-hosted pastebin software written in PHP. Pastes are editable, forkable, may have multiple files and are stored in git repositories.
https://cweiske.de/phorkie.htm
GNU Affero General Public License v3.0
216 stars 23 forks source link

Configurable index page. #5

Closed jnovack closed 12 years ago

jnovack commented 12 years ago

Configurable index page for those who want listing primary vs those who want pasting primary.

Notes: diff --git a/data/templates/index.htm b/data/templates/index.htm deleted file mode 100644 index 5752c1e..0000000 --- a/data/templates/index.htm +++ /dev/null

Yeah, the diff shows deleting index, but github does not. If you click "Files Changed" -> "Show Diff Stats", it shows it properly.

cweiske commented 12 years ago

Why did you close the pull request? Please also change the main menu to let the "new" button point to /new

jnovack commented 12 years ago

That was one reason, I forgot the new button. I also forgot to update README.rst, and I wanted to get rid of the newline problems (since I'm updating on linux, I'm gathering you are using windows?)

But mostly, because I had to destroy my repo, as I was experimenting with setting up a clean repo with feature branches properly.

I've not used git to it's fullest extent (utilizing branches, merging, etc), I've only used it for "oh shit, revert" and diffs. So best practices are still a little foreign to me.

Justin J. Novack

On Fri, Sep 14, 2012 at 2:27 PM, Christian Weiske notifications@github.comwrote:

Why did you close the pull request? Please also change the main menu to let the "new" button point to /new

— Reply to this email directly or view it on GitHubhttps://github.com/cweiske/phorkie/pull/5#issuecomment-8571136.

cweiske-mirror commented 12 years ago

Hello Justin,

That was one reason, I forgot the new button. I also forgot to update README.rst, and I wanted to get rid of the newline problems (since I'm updating on linux, I'm gathering you are using windows?) No, I'm on linux and I always use unix newlines.

Regards/Mit freundlichen Grüßen Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-