search

cwendt94 / espn-api

ESPN Fantasy API! (Football, Basketball)
MIT License
544 stars 183 forks source link

Incorrect names for tiebreaker settings #399

Closed DesiPilla closed 1 year ago

DesiPilla commented 1 year ago

Sport

Football

Summary

In my fantasy football league, ties for playoff seedings are settled by a team's total points for. There are no tiebreakers for regular season matchups.

image

However, I noticed that league.settings.playoff_seed_tie_rule returned NONE for my team. This is not correct. I assume that this field is intended to contain that setting, as the ESPN UI displays the setting as "Playoff Seeding Tie Breaker".

Unless I am misinterpreting the intent of this setting, I believe this needs to be corrected.

Logs/Data

No response

DesiPilla commented 1 year ago

It appears that data['scheduleSettings']['playoffSeedingRule'] contains the information behind playoff seeding tiebreakers. data['scoringSettings']['playoffMatchupTieRule'] would seem to be the playoff-version of data['scoringSettings']['matchupTieRule']. I'm not sure exactly what it means for playoffMatchupTieRule to be NONE (as it is in the case of my league), since one of the two teams must advance, but this is nevertheless distinct from tiebreakers for playoff seeding.

DesiPilla commented 1 year ago

Proposed pull request to make this change.

cwendt94 commented 1 year ago

Thanks for catching this and creating a PR!