cwendt94 / espn-api

ESPN Fantasy API! (Football, Basketball)
MIT License
544 stars 183 forks source link

fix: Use more accurate naming for settings #400

Closed DesiPilla closed 1 year ago

DesiPilla commented 1 year ago

Currently, the attribute league.settings.playoff_seed_tie_rule is assigned the value from data['scoringSettings']['playoffMatchupTieRule']. This is the rule used when there are ties in playoff matchups, not the rule used when there are ties for playoff seeding. That rule can be found in data['scheduleSettings']['playoffSeedingRule'].

This PR renames the old attribute league.settings.playoff_tie_rule (to be similar to league.settings.tie_rule, as these are similar settings), and instead assign league.settings.playoff_seed_tie_rule to the tiebreaker used when deciding playoff seeding.