cwendt94 / espn-api

ESPN Fantasy API! (Football, Basketball)
MIT License
544 stars 183 forks source link

Add draft support for basketball #424

Closed cjwin2000 closed 1 year ago

cjwin2000 commented 1 year ago

Implements draft support for basketball. Copied over from the football implementation. Only change is the string representation in order to better display the round and pick number.

This should probably be moved to a base pick class, similar to what is planned for players with #124 , but this should do for now. Might also be worth considering adding a player object member instead of the separate name and id-- similar to how the team member is a team object

codecov-commenter commented 1 year ago

Codecov Report

Base: 80.73% // Head: 81.08% // Increases project coverage by +0.35% :tada:

Coverage data is based on head (7d1b1db) compared to base (6d4a054). Patch coverage: 91.17% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #424 +/- ## ========================================== + Coverage 80.73% 81.08% +0.35% ========================================== Files 59 60 +1 Lines 2050 2083 +33 ========================================== + Hits 1655 1689 +34 + Misses 395 394 -1 ``` | [Impacted Files](https://codecov.io/gh/cwendt94/espn-api/pull/424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Wendt) | Coverage Δ | | |---|---|---| | [espn\_api/basketball/pick.py](https://codecov.io/gh/cwendt94/espn-api/pull/424/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Wendt#diff-ZXNwbl9hcGkvYmFza2V0YmFsbC9waWNrLnB5) | `85.71% <85.71%> (ø)` | | | [espn\_api/basketball/league.py](https://codecov.io/gh/cwendt94/espn-api/pull/424/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Wendt#diff-ZXNwbl9hcGkvYmFza2V0YmFsbC9sZWFndWUucHk=) | `85.44% <95.00%> (+4.14%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Wendt). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Wendt)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

cwendt94 commented 1 year ago

Thanks again for another PR!

I agree, this could definitely be moved to a base class! I will add it to my TODO for some of the refactoring working I have been wanting to do.

cjwin2000 commented 1 year ago

Happy to contribute to the project. Thanks for maintaining it! I'll poke around and see if there's some other stuff I can help with as well