Closed cjwin2000 closed 1 year ago
Base: 80.73% // Head: 81.08% // Increases project coverage by +0.35%
:tada:
Coverage data is based on head (
7d1b1db
) compared to base (6d4a054
). Patch coverage: 91.17% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks again for another PR!
I agree, this could definitely be moved to a base class! I will add it to my TODO for some of the refactoring working I have been wanting to do.
Happy to contribute to the project. Thanks for maintaining it! I'll poke around and see if there's some other stuff I can help with as well
Implements draft support for basketball. Copied over from the football implementation. Only change is the string representation in order to better display the round and pick number.
This should probably be moved to a base pick class, similar to what is planned for players with #124 , but this should do for now. Might also be worth considering adding a player object member instead of the separate name and id-- similar to how the team member is a team object