Closed spkane31 closed 9 months ago
I tested this locally to confirm it does not contain any breaking changes to functionality, only adding a new member variable
Patch coverage: 100.00%
and project coverage change: -0.01%
:warning:
Comparison is base (
81f8967
) 80.36% compared to head (81d853a
) 80.36%. Report is 13 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks good, thanks for adding this!
This PR adds a
Team
type annotation for theMatchup
class. Currently, the id is written (as an int) and then in a loop it is dynamically changed to aTeam
. I made a change to store the id in a separate variable_{home,away}_team_id
and then uses that variable in the loop to set theteam
. I noticed this 'issue' while working in VS Code and the type annotation wasn't populating, this should make for a slightly improved developer experience