cwendt94 / espn-api

ESPN Fantasy API! (Football, Basketball)
MIT License
544 stars 183 forks source link

added missing hockey stat fields names #481

Closed alexindaco closed 8 months ago

alexindaco commented 8 months ago

I forget where I figured this out, but in my own personal scripts I had notes on stats that were not labelled here. 19 is Power Play Assists 35-37 is Special Teams Points STP = STPG (Goals) + STPA (Assists) STPG = PPG (Power Play) + SHG (Short Handed) STPA = PPA + SHA

Also, I'm fairly certain that stat '30' is a global version of GP (Games Played). This can be useful for Goalies whose primary game count fantasy stat is GS, Games Started (at least thats why my league uses). Games Started only increments when the goalie is the starting goalie, so stat '30' would tell you the total number of games a goalie participated in in a given period. stat '30' also seems to be populated for skaters with the same value that is present in GP.

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (eada007) 80.42% compared to head (641e805) 80.42%. Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #481 +/- ## ======================================= Coverage 80.42% 80.42% ======================================= Files 59 59 Lines 2094 2094 ======================================= Hits 1684 1684 Misses 410 410 ``` | [Files](https://app.codecov.io/gh/cwendt94/espn-api/pull/481?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Wendt) | Coverage Δ | | |---|---|---| | [espn\_api/\_version.py](https://app.codecov.io/gh/cwendt94/espn-api/pull/481?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Wendt#diff-ZXNwbl9hcGkvX3ZlcnNpb24ucHk=) | `100.00% <100.00%> (ø)` | | | [espn\_api/hockey/constant.py](https://app.codecov.io/gh/cwendt94/espn-api/pull/481?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Christian+Wendt#diff-ZXNwbl9hcGkvaG9ja2V5L2NvbnN0YW50LnB5) | `100.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cwendt94 commented 8 months ago

Thanks for updating these stats!