search

cwendt94 / espn-api

ESPN Fantasy API! (Football, Basketball)
MIT License
613 stars 198 forks source link

Update hockey positions #505

Closed samthom1 closed 10 months ago

samthom1 commented 10 months ago

Hockey positions don't hold the same key:value relationship between the eligibleSlots and lineupSlot fields and the position field under player.py.

Modified constant.py to match the eligibleSlots and lineupSlot values (which has an extra 'Forward' value) and reconfigured the Player() init to account for the mismatch in keys.

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cac4300) 80.53% compared to head (7f52448) 80.53%. Report is 2 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #505 +/- ## ======================================= Coverage 80.53% 80.53% ======================================= Files 59 59 Lines 2106 2106 ======================================= Hits 1696 1696 Misses 410 410 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cwendt94 commented 10 months ago

Wow this is interesting, I wonder why ESPN just didn't use the same ids.