Closed DesiPilla closed 6 months ago
Attention: 9 lines
in your changes are missing coverage. Please review.
Comparison is base (
62700b2
) 80.60% compared to head (73bab47
) 81.03%.
Files | Patch % | Lines |
---|---|---|
espn_api/football/helper.py | 91.89% | 6 Missing :warning: |
espn_api/football/league.py | 87.50% | 3 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@cwendt94 looks like we don't have any test leagues that use H2H_RECORD
as the tiebreaker, but otherwise this PR is set.
@DesiPilla could you move all of the helper functions in its own file helper.py
so that we don't bloat the league object.
@cwendt94 I agree that's the cleaner way to do it. I moved everything over now. I'm making some test cases for the sorting criteria that don't get run by default so that we have better code coverage.
Thank you, this is looking good!
@cwendt94 alright the coverage should be good now.
@DesiPilla great work and thanks for adding the coverage!
This PR is to replace another attempt.
The tiebreaking process is quite complicated, but this follows all tiebreaking levels, subject to a league's specific tiebreaker rules.