search

cwensley / Portable.Xaml

Portable .NET library for reading/writing xaml files.
Other
157 stars 39 forks source link

Fix markup extension lookup behavior. #117

Closed grokys closed 6 years ago

grokys commented 6 years ago

System.Xaml doesn't rely on the XamlSchemaContext.GetXamlType method to lookup both Foo and FooExtension when "{Foo}" is encountered: it queries first for FooExtension and then for Foo.

This is important if the XamlSchemaContext.GetXamlType is overridden and the overridden method does not call base.GetXamlType then Portable.Xaml can fail where System.Xaml succeeds.

Note that GetXamlType does still need to perform the dual lookup, and no - this makes no sense either.

Depends on #113 Depends on #116

cwensley commented 6 years ago

Ah yes I believe it does this when looking up the initial extension, but it wasn't done within the markup extension parsing. Thanks again!!