search

cwensley / pablodraw

PabloDraw is an Ansi/Ascii text and RIPscrip vector graphic art editor/viewer with multi-user capabilities.
MIT License
324 stars 22 forks source link

Increased Zoom level and added AutoSave and Backup in PabloDraw.Console #19

Open DavStas opened 6 years ago

DavStas commented 6 years ago
christianvozar commented 6 years ago

@cwensley Some features to review and possibly merge into master. I have been running the macOS build of this and the features work as explained (+1)

cwensley commented 6 years ago

First of all, thanks a ton for helping improve PabloDraw! This is excellent!

I think with the autosave it can only save to ".ans" or ".rip" and the Document.Info.DefaultFormat is not guaranteed to be RIP format. Also, what if they want to save as .xb, or some other format?

What might make sense here is to simply save the document to the file name provided in the command line via Document.FileName. If the file name isn't provided, then you could use a sensible default (like "AutoSave" as you have already done) using the extension from Document.Format.Extensions[0].

Also something to consider, is the Timer will be running in a different thread as the server, so saving using that thread might cause an exception as I think it's accessing non-thread safe objects. Not sure what would need to be done to allow for that, but something to think about.

Thanks again!

Kirkman commented 1 year ago

Hi @cwensley, would you consider incorporating the increased zoom level support from this pull request, for drawing RIP?

Like @christianvozar in issue #17, I find it really difficult to draw pixel art when the zoom is limited to a maximum of 200%. Much higher zooms, maybe up to 800%, would be so useful.

cwensley commented 1 year ago

@Kirkman absolutely, though have you tried the "Expand to Fit" option? It stretches the canvas to the width of the window.