search

cwerner / fastclass

Little tools to download and then weed through images, delete and classify them into groups for building deep learning image datasets (based on crawler and tkinter)
Apache License 2.0
133 stars 25 forks source link

using navigation keys with fcc throws KeyError 'c' #15

Closed H4dr1en closed 5 years ago

H4dr1en commented 5 years ago

Using navigation keys (with Left, Up, Down, Right) not in the num pad throws following error:

Traceback (most recent call last): 
File "...\envs\py3\lib\tkinter\__init__.py", line 1705, in __call__ return self.func(*args)
File "...\envs\py3\lib\site-packages\fastclass\fc_clean.py", line 133, in callback button_action(event.char)                                                                                                                    File "...\envs\py3\lib\site-packages\fastclass\fc_clean.py", line 129, in button_action self._class[f'c{char}'].add(self.filelist[self._index]) 
KeyError: 'c'

The callback function should always use event.keysym to avoid such problems. I fixed it and will open a PR.

cwerner commented 5 years ago

Thanks!

Excellent, yes please open a PR.