Installer doesn't differentiate different node installations

cwernert / swiftbar-zapier

A plugin for the SwiftBar app, which aims to present content collected by Zapier.

2 stars 0 forks source link

Installer doesn't differentiate different node installations #8

Open cwernert opened 2 years ago

cwernert commented 2 years ago

MacOS can have node in various spots, and it looks like (verify) SwiftBar requires it to be in the standard dir: /usr/local/bin/node If Node is installed via NVM, it will be at: ~/.nvm/versions/node

Need to:

Verify that swiftbar needs node in the standard dir
Update the installer to check for and enforce this

cwernert commented 2 years ago

Might be able to do this simply by expecting this result from which node: /usr/local/bin/node

cwernert commented 2 years ago

Also not sure if relevant, but the shebang seems to be the reason the plugin throws an error - maybe this could be set dynamically? #!/usr/bin/env /usr/local/bin/node

cwernert commented 2 years ago

I reduced the specificity of the shebang on both node js files, so that instead of referring to node with an absolute path, it now relies on env finding the user's node installation. Dayne will test this when reinstalling