cwi-dis / vr2gather-orchestrator-v2

Typescript-based version of the VR2Gather orchestrator
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

assignExternalTransport error handling isn't correct #13

Closed jackjansen closed 7 months ago

jackjansen commented 7 months ago

In assignEternalTransport() there's a catch-all try/except that doesn't seem right.

First of all, all errors give a No config for protocol type... message, even though something completely different could be wrong (such as: there is a config, but it has errors, or something else went wrong in the code).

Second, I think we shouldn't fall back to SocketIO transport, we should simply abort the session. The VR2Gather instance won't be able to handle fallback anyway, might as well tell it straight away that it didn't work.

And finally I don't think that its falling back to SocketIO, I think its falling back to no transport at all.