search

cwi-dis / vr2gather-orchestrator-v2

Typescript-based version of the VR2Gather orchestrator
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Wrong path to TCP reflector code #34

Closed jvdrhoof closed 2 months ago

jvdrhoof commented 2 months ago

In the sample config file for TCP reflector, the following is mentioned:

"commandLine": [
    "python3",
    "/code/tcpreflector/tcpreflector.py",
    "--host",
    "0.0.0.0",
    "--port",
    "%SFU_PORT%"
  ]

This results in:

SystemException: TransportProtocolTCPSFU: tcp://193.190.127.250:8089: No connection could be made because the target machine actively refused it.

This is because the code for TCP reflector is in tcpreflector/tcpreflector.py. Modifying this line results in a valid session.

troeggla commented 2 months ago

I'm not quite sure I understand the problem. The SFU launches for me just fine with the given config.

jvdrhoof commented 2 months ago

The directory code does not exist. The config file however mentions /code/tcpreflector/tcpreflector.py. For us, TCP reflector only works after changing this configuration setting to /tcpreflector/tcpreflector.py.

troeggla commented 2 months ago

Ah I see. That path is set up for running inside a container, which mounts the directory tree under /code inside the container.

troeggla commented 2 months ago

I made the change you requested, since the relative path also works inside the container.