cwi-dis / vr2gather-orchestrator-v2

Typescript-based version of the VR2Gather orchestrator
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Dangling connections #8

Open ashutosh3308 opened 8 months ago

ashutosh3308 commented 8 months ago

As to @ashutosh3308 's proiblem today, with no handler installed for UpdateUserDataJson: there is some sort of an issue in the orchestrator.

It seems as though somehow an old session from user fiddlehead didn't get cleaned up, and this is causing the problems.

After rebooting fiddlehead, here is what the orchestrator dump says:

{ id: '05b79e9d-7c6e-436b-ad3a-df21ce1a8552',
  sessions: [],
  users:
   [ { userId: 'b99fecb8-5b19-4d04-99d6-344fc0f5665e',
       userName: 'fiddlehead',
       userData: {},
       sfuData: {} } ] }

I'm not sure what happens when user fiddlehead tries to login again, maybe this is what causes the problem?

I think it might be good to store some telemetry data in the users objects, for example peer host/port, and maybe "last activity time".

troeggla commented 8 months ago

This is a connection which is still open. I'm not sure whether this is actually the problem, but if you have an open connection and try to log in with the same username again, that new connection will be assigned the socket from the original connection.

This is a bug and I'll look into it, but it may or may not fix your issue.