search

cwill747 / angular-libphonenumber

nathanhammond/libphonenumber as an angular input mask
Other
40 stars 28 forks source link

Bower install should automatically install both files #75

Open jammed343 opened 7 years ago

jammed343 commented 7 years ago

Expected Behavior

bower install --save angular-libphonenumber Should include both files with tools like gulp / wiredep

Currently it just includes

Add libphonenumber.js to main in bower.json

Steps to Reproduce (for bugs)

  1. Use gulp/wiredep
  2. bower install --save angular-libphonenumber
  3. Error about phoneUtils
cwill747 commented 7 years ago

The only problem with this approach is what I have here. I give the option of choosing which libphonenumber you want to include, which this would prevent. Should we just set a sane default?

jammed343 commented 7 years ago

@cwill747

Ideally we would be able to include libphonenumber as a dependency instead, and not have it edited and included in this project.

I tried using https://github.com/nathanhammond/libphonenumber as an example but It didnt work, had an error of a function could not be found.

cwill747 commented 7 years ago

Yeah - I use a fork of his library to include the function that's needed for this lib, hence the edited version. Maybe I can just published the edited version as a scoped package or something...

jammed343 commented 7 years ago

Ive only just been introduced to Google libphonenumber. I assumed there would be one version that could be relied upon in bower. I'm not sure why Google packages all languages together in https://github.com/googlei18n/libphonenumber

So I'm not sure if its best to just save the modified https://github.com/nathanhammond/libphonenumber separately or pull your changes into his repo. In an ideal world libphonenumber could just come directly from google.

jlf123 commented 7 years ago

I would also like to see this issue resolved.

yeluolei commented 7 years ago

wish to see this problem resolved. upgrade to new version of libphonenumber is too hard now.