cwilso / AudioRecorder

Simple live audio file recorder, based on RecorderJS
MIT License
421 stars 168 forks source link

Possible Error in RecorderWorker.encodeWAV #25

Open jakelewis3d opened 6 years ago

jakelewis3d commented 6 years ago

line 134: view.setUint32(4, 32 + samples.length * 2, true);

Shouldn't this be 36 rather than 32? on line 128 you assign a buffer: var buffer = new ArrayBuffer(44 + samples.length * 2); and write 8 bytes into it, so it would figure that the next length would be 8 bytes smaller, ie 36. And from a quick count there does appear to be 36 bytes written prior to the Also see http://soundfile.sapp.org/doc/WaveFormat/