Thank you, this is awesome!

cwilso / PitchDetect

Pitch detection in Web Audio using autocorrelation

https://cwilso.github.io/PitchDetect/

MIT License

1.3k stars 437 forks source link

Thank you, this is awesome! #25

Open theronic opened 6 years ago

theronic commented 6 years ago

I mainly compose through whistling and I've been meaning to make a little whistle detector that will jot down a melody for me so I can develop it further in the browser.

I'd like to use this and build it out. Now that it's a few years down the line, can you comment on the efficacy of your pitch detection approach and if there are other approaches to consider?

Thank you! Never stop making music :)

Pranoy1c commented 6 years ago

Since there's no reply, I would like to share my experience. Unfortunately, I found this to be extremely inaccurate with my Piano at least. Pressing the A4 (440) shows A4 for a tiny millisecond but then jumps around to E and then disappears. Testing others notes don't even show correctly and just jump around. So I would not recommend this.

Seanitzel commented 5 years ago

@Pranoy1c Well, i honestly dont know what your talking about because i tested it with my voice, a piano, guitar, ukelele and it returned super accurate results every single time. im using it for my project and it works perfectly.