search

cwilso / WebMIDIAPIShim

Polyfill using the Jazz NPAPI MIDI plugin to implement the Web MIDI API on Mac and Windows.
380 stars 53 forks source link

Need to update to match current spec/Chrome implementation #41

Closed tringenbach closed 9 years ago

tringenbach commented 10 years ago

I tried to follow the example to play middle C:

var output = midiAccess.outputs.entries[indexOfPort];

But outputs seems to be a function and that code didn't work, and I ended up doing:

var output = midiAccess.outputs()[indexOfPort];

That worked, but it seems like that doesn't follow the spec. I suspect inputs is the same way, but I haven't gotten that far yet.

cwilso commented 10 years ago

Yep, I haven't updated the shim yet to the latest standard.

tringenbach commented 10 years ago

Ah ok. I wasn't sure. I looked at the December and Nov drafts and they both looked the same in that regard.

Is there a certain version of the standard that is implemented? That will help me write code that works now, and I can update it as the shim updates.

Is updating to the latest standard something you expect to do/have time for is the near term? If not I might consider trying to my hand at it and submitting a patch. (Or are you expecting major changes in the draft soon, in which case it's probably better to wait anyway)

Thanks.

cwilso commented 10 years ago

Well, it's close to what the Chrome implementation looks like currently. The draft is not planned to change much; I'll probably update the shim when Chrome ships its updates to match the spec (in a month or so).

On Mon, Jan 6, 2014 at 8:42 PM, tringenbach notifications@github.comwrote:

Ah ok. I wasn't sure. I looked at the December and Nov drafts and they both looked the same in that regard.

Is there a certain version of the standard that is implemented? That will help me write code that works now, and I can update it as the shim updates.

Is updating to the latest standard something you expect to do/have time for is the near term? If not I might consider trying to my hand at it and submitting a patch. (Or are you expecting major changes in the draft soon, in which case it's probably better to wait anyway)

Thanks.

— Reply to this email directly or view it on GitHubhttps://github.com/cwilso/WebMIDIAPIShim/issues/41#issuecomment-31713037 .

abudaan commented 9 years ago

I have updated my fork of the shim to the latest W3C draft.

I have updated/fixed all tests as well and I made a wrapper for the older WebMIDI implementation in Chromium.

Will send a pull request later today.

mscuthbert commented 9 years ago

I believe this has been fixed? Is the issue closed?

cwilso commented 9 years ago

oops! Yes.