search

cwindolf / dartsort

20 stars 4 forks source link

peeler empty result should have the same structure as a normal chunk #15

Closed oliche closed 5 days ago

oliche commented 2 weeks ago

This allows the drift correction of iblsorter to run with the latest version of the code.

cwindolf commented 2 weeks ago

Thanks for this! I had also been working on this with a dict approach. Do these commits fix your issue?

oliche commented 1 week ago

Yes that works for me ! So I've rebased on main.

Next issue is this temporal_slice attribute missing on my transformer. I was able to fix it this way, but it looks like the constructor has not been called properly ?

Anyways with the blurb above, it seems to be working for me ATM: https://github.com/cwindolf/dartsort/pull/15/commits/04a23714d77f28c1bbf3351ed9e21601395d1bca