search

cwindolf / dartsort

18 stars 2 forks source link

Is it ready to test ? #8

Open samuelgarcia opened 12 months ago

samuelgarcia commented 12 months ago

Salut à tous.

Any plan to make a main entry point for dartsort ? I belong to a fan base and we would like to make some early test of dartsort.

Line 30 on main.py is annoucing # coming soon. Are you doing a marketing plan like apple delaying a bit the release of the new phone to make users impatient ?

I propose to start a PR on spikeinterface side with a wrapper that will use this function and in parralel you make this function. Deal ?

Bonne journée

samuelgarcia commented 12 months ago

Here a simple draft for a wrapper in spikeinetrface https://github.com/SpikeInterface/spikeinterface/pull/2125

We need to discuss which parameters you want to expose.

cwindolf commented 12 months ago

Thanks Sam -- we'll let you know when things are ready. Don't start getting impatient quite yet :)

samuelgarcia commented 12 months ago

You don't like my joke ? don't worry take your time. it was a very friendly ping.

cwindolf commented 12 months ago

Haha for sure, thanks! Glad to have the wrapper ready and waiting for us

samuelgarcia commented 1 week ago

One year after the first joke, I think it is time to ask again if this is ready for testing. The wrapper in spikeinterface is getting moldy.

cwindolf commented 1 week ago

No :)