Closed timmattison closed 7 years ago
Yes, windows will say it can't find node.
On Tue, Sep 6, 2016 at 5:18 PM, Tim Mattison notifications@github.com wrote:
Changing the interpreter path to /usr/bin/env node from just node will make this work for many more people (at least on Linux and MacOS) out of
the box. I'm not sure if this has any effect on Windows users.
You can view, comment on, or merge this pull request online at:
https://github.com/cwjohan/markdown-to-html/pull/7 Commit Summary
- Changed to /usr/bin/env node
File Changes
- M bin/github-markdown https://github.com/cwjohan/markdown-to-html/pull/7/files#diff-0 (2)
- M bin/github-markdownb https://github.com/cwjohan/markdown-to-html/pull/7/files#diff-1 (2)
- M bin/markdown https://github.com/cwjohan/markdown-to-html/pull/7/files#diff-2 (2)
- M bin/markdownb https://github.com/cwjohan/markdown-to-html/pull/7/files#diff-3 (2)
Patch Links:
- https://github.com/cwjohan/markdown-to-html/pull/7.patch
- https://github.com/cwjohan/markdown-to-html/pull/7.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cwjohan/markdown-to-html/pull/7, or mute the thread https://github.com/notifications/unsubscribe-auth/AH5q3DAKxBnIM0oeMzPkVL5YrKvU4Hfnks5qngLSgaJpZM4J2agc .
Changing the she-bang line to use /usr/bin/env node, which for Unix/Linux users will use their path variable to find the node executable.
Changing the interpreter path to /usr/bin/env node from just node will make this work for many more people (at least on Linux and MacOS) out of the box. I'm not sure if this has any effect on Windows users.