Why are react, react-dom, styled-components dependencies, not dev and peer dependencies?

cwlsn / rinse-react

🚿 Rinse, React, repeat. A boilerplate to build a React component library.

https://rinsejs.io/

MIT License

158 stars 43 forks source link

Why are react, react-dom, styled-components dependencies, not dev and peer dependencies? #37

Open dwjohnston opened 4 years ago

dwjohnston commented 4 years ago

Given that the intention that these components should only be used by other projects, shouldn't react, etc be a peer dependency?

ExLeonem commented 4 years ago

Moving react and react-dom to peerDepencies would make sense. But I think styled-components should be kept under regular dependencies, otherwise users are required to install styled-components even if they don't use them.