search

cwmonkey / reactor-knockoff

26 stars 31 forks source link

It just broke #21

Closed Epicminer26390 closed 5 years ago

Epicminer26390 commented 5 years ago

I came back to this after a year and i cannot place anything nothing at all. I don't know what broke but i would like it fixed.

asl97 commented 5 years ago

Let me just says it still works for me.

Without giving some kind of error message, logs, or really anything useful, unless cwmonkey can somehow reproduce your issue, it would be impossible to fix whatever that broke for you.

"It just broke" isn't very helpful.

Epicminer26390 commented 5 years ago

Screenshot 2019-09-23 at 8 29 31 AM

This is what happens I click on the cell it does not turn green and stays grey, then it does not allow me to place it.

asl97 commented 5 years ago

Again, not really useful, all that tells me is that some kind of error might have happened and it most likely stopped the javascript event loop but not the error itself or the cause.

If you really don't know where to look, look up "browser console" on a search engine, on most browser, f12 should bring it up.

Epicminer26390 commented 5 years ago

so I don't know what happened but i was screwing around with the website it started to work again so :P

Epicminer26390 commented 5 years ago

Never mind it broke unfortunately, so what do you want me to do just open view page source?

asl97 commented 5 years ago

image ^Console

If there is an error, it would be in red.

1993mrc commented 5 years ago

123456

I have the same issue

1993mrc commented 5 years ago

1234567

It appears also on newest version

asl97 commented 5 years ago

This is due to undocumented changes that chrome did, they added something call part to the dom interface.

@1993mrc I doubt I caught every usage of part but it seem to work, let me know if it's still broken somewhere.

1993mrc commented 5 years ago

so I have a big request to You, can you help me with solving that issue? at this moment is the only place where it appears but it completely breaks the game. On Microsoft Edge it works correctly but there are another problem with resolution - it "jumps" and expand on available place on screen (when browser window is minimized to game scale it only "jumps" to few pixels)

asl97 commented 5 years ago

@1993mrc if you mean this issue, I have already pushed the fix to my fork. as for the "jumps", I don't quite understand the issue, if it affect cwmonkey version too, I would appreciate it if you create another seperate issue for it.

cwmonkey commented 5 years ago

Ew. Fixed in 754a441de9c91b226faace94ea092a447429b398 hopefully.

asl97 commented 5 years ago

:rofl: you even changed the description, kind of overkill but should totally catch everything.

cwmonkey commented 5 years ago

Oh dammit I thought I fixed all those :P