search

cwoac / thingy_grabber

Script for archiving thingiverse things
MIT License
39 stars 10 forks source link

Error downloading thatevilone #10

Closed joebywan closed 4 years ago

joebywan commented 4 years ago

Not sure what's occurring here. It creates the folder "3389073 - only in death". Nothing is in it though.

Downloading thing 27 - 3389073 Looking for old dir at ./stls/thatevilone designs\only in death... Traceback (most recent call last): File "D:\waste\thingygrabber\thingy_grabber.py", line 660, in main() File "D:\waste\thingygrabber\thingy_grabber.py", line 646, in main Designs(user, args.directory, args.quick).download() File "D:\waste\thingygrabber\thingy_grabber.py", line 240, in download RC = Thing(thing).download(self.download_dir) File "D:\waste\thingygrabber\thingy_grabber.py", line 451, in download with open(filelist_file, 'w', encoding="utf-8") as fl_handle: FileNotFoundError: [Errno 2] No such file or directory: './stls/thatevilone desi gns\3389073 - only in death...\filelist.txt'

I know I've been posting a ton of issues, this is the only one it tripped up on now after that last update. It's not eating all of my ram too :) Thanks for your help.

cwoac commented 4 years ago

Huh, weird, it works for me. Maybe a weird windows interaction? Will try on my windows machine later.

joebywan commented 4 years ago

Does it generate the same foldername for that thing?

On Thu, Apr 16, 2020 at 8:37 PM Oliver Matthews notifications@github.com wrote:

Huh, weird, it works for me.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cwoac/thingy_grabber/issues/10#issuecomment-614567142, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABE6654ORHEVWST6AU5OVELRM3NYLANCNFSM4MI7OKAQ .

joebywan commented 4 years ago

Are you on win7? I had a look further into it and the name of the thing has 3 trailing ...

When I try adding that to the folder name it disappears for a second or two and reappears without the ...

I believe it might be an issue with windows. Could ... be added to the sanitising to remove please?

I did notice there was one or two other errors I got in my last runthrough, I'm running it through again and will paste them up for you.

cwoac commented 4 years ago

Right, so windows does not allow filenames that end in periods, and it is autostripping them on the create but not on the exists call.