cwoac / thingy_grabber

Script for archiving thingiverse things
MIT License
39 stars 11 forks source link

firefox process spawning spam #8

Closed joebywan closed 4 years ago

joebywan commented 4 years ago

I tried running it using the batch command, and it stops when it hits that unicode error, so I then tried it using a for loop batch file. Problem is the amount of firefox processes that are being spawned while running it.

I only noticed when my machine freaked out with no space on C:.. After looking into it, it had spawned over 300 firefox processes, topping out my 32GB of ram causing massive offloading into the swapfile bloating it out to over 60GB filling my drive.

After noticing this I re-ran with the batch switch to see if it had the same issue, and it seems to.

I think you need to force some sort of cleanup after a user's done to ensure all of the browser processes have been closed.