Closed mturczyn closed 1 week ago
During reading of the book, I have noticed couple of typos and also came up with couple of sugggestions.
So far I am at Chapter 4 (just finished 3), so those remarks cover only first 3 chapters:
internetInternet
One of the most fundamental network protocols is the Internet Protocol ( IP ), which forms the foundation of the internetInternet
typo subsectionUnderstanding
subsectionUnderstanding
This subsectionUnderstanding socket addressing delves into the intricacies of socket addressing its intricacies
Code sample with wrong comment
// Place the socket in a non-blocking mode serverSocket.Blocking = true;
typo:
In this chaptere upcoming subsections
typo (trailing slashes):
and professional-grade applications. ///
C# remark - sending chunked data is now different, and is one of the Socket.SendAsync overloads
Socket.SendAsync
public static async Task<int> SendDataToServerAsync( Socket clientSocket, byte[] dataToSend, bool chunked, CancellationToken cancellationToken) { // Send the serialized data to the server var sentBytes = chunked ? await clientSocket.SendAsync( dataToSend .Chunk(CHUNK_SIZE) .Select(x => new ArraySegment<byte>(x)) .ToList()) : await clientSocket.SendAsync(dataToSend, cancellationToken); return sentBytes; }
behind each of these taskstask is
C# remark: ConcurrentBag maybe instead of lock and List
ConcurrentBag
lock
List
typo
experience for usersuser experience
C# remark: in code examples there is usually Socket.Close method, why not Dispose and/or using?
Socket.Close
Dispose
using
typo in one of subtitles: Monitoring and ILogging
Monitoring and ILogging
During reading of the book, I have noticed couple of typos and also came up with couple of sugggestions.
So far I am at Chapter 4 (just finished 3), so those remarks cover only first 3 chapters:
Chapter 2
internetInternet
Chapter 3
typo
subsectionUnderstanding
Code sample with wrong comment
typo:
typo (trailing slashes):
C# remark - sending chunked data is now different, and is one of the
Socket.SendAsync
overloadstypo:
C# remark:
ConcurrentBag
maybe instead oflock
andList
typo
C# remark: in code examples there is usually
Socket.Close
method, why notDispose
and/orusing
?typo in one of subtitles:
Monitoring and ILogging