Luciano Frizzera 23 days ago
There is also an assumption of a master branch when loading a file. So, the new file saved under main will not be listed on GitWriter. If I change the load dialog to list main , than we will lose access to all the repos that have master as default branch.
Luciano Frizzera 23 days ago
So, the right solution. 1. switch to main as default branch (quick and easy) and 2. allow users to choose the branch when saving and loading (this may take time - a week maybe).
Luciano Frizzera 23 days ago
The palliative solution: rename the default branch to master at the time of repo’s creation. GitHub says that this is fast, but can take a few minutes (maybe in the case of the branch having a large number of files).
Luciano Frizzera 23 days ago
So, did the palliative solution and pushed the code.
Luciano Frizzera 23 days ago
However, since this repo (Git-dialogs) wasn’t not merge to production since Dec 2020, I’m afraid it might break the main repo (write-base).
Luciano Frizzera 23 days ago
This has to do with jquery version.
susan_brown 23 days ago
So don’t update right now! Fascinating backstory.
:+1:
1
Luciano Frizzera 23 days ago
I will check is I can fixed an issue preventing me to update dev-cwrc-write. If I can solve it today, I will let you know.
Luciano Frizzera 23 days ago
The palliative solution for this case will be working on dev.
Luciano Frizzera 23 days ago
Together with the new validator.
Full slack discussion from https://cwrcteam.slack.com/archives/C9YR1Q99N/p1621893887052600:
Luciano Frizzera 23 days ago There is also an assumption of a master branch when loading a file. So, the new file saved under main will not be listed on GitWriter. If I change the load dialog to list main , than we will lose access to all the repos that have master as default branch.
Luciano Frizzera 23 days ago So, the right solution. 1. switch to main as default branch (quick and easy) and 2. allow users to choose the branch when saving and loading (this may take time - a week maybe).
Luciano Frizzera 23 days ago The palliative solution: rename the default branch to master at the time of repo’s creation. GitHub says that this is fast, but can take a few minutes (maybe in the case of the branch having a large number of files).
Luciano Frizzera 23 days ago So, did the palliative solution and pushed the code.
Luciano Frizzera 23 days ago However, since this repo (Git-dialogs) wasn’t not merge to production since Dec 2020, I’m afraid it might break the main repo (write-base).
Luciano Frizzera 23 days ago This has to do with jquery version.
susan_brown 23 days ago So don’t update right now! Fascinating backstory. :+1: 1
Luciano Frizzera 23 days ago I will check is I can fixed an issue preventing me to update dev-cwrc-write. If I can solve it today, I will let you know.
Luciano Frizzera 23 days ago The palliative solution for this case will be working on dev.
Luciano Frizzera 23 days ago Together with the new validator.