cwrc / CWRC-Schema

CWRC Schemas and supporting documents
GNU General Public License v3.0
4 stars 4 forks source link

wierdness with production element #89

Closed ghost closed 5 years ago

ghost commented 9 years ago

This issue should really be called "wierdness with splitting elements"

Inside a P tag inside PRODUCTION, when I want to split the tag, I can't split the P tag directly, but only the PRODUCTION tag, which produces a new P tag as well, but unnecessarily multiplies the PRODUCTION tag. I can then move the text I want in the new P tag, along with the P tag, into the original PRODUCTION tag, and delete the PRODUCTION tag, and everything is just fine, but it is cumbersome: we should be able to split the P tag directly. Can you figure out why this is happening this way?

I just checked it with other tags and it's all the same: it wants to split the higher-level tag, not the one that the cursor is immediately within. This does not seem to be the case within TEXTUALFEATURES but it is also the case with RECEPTION.

this clip is from the Talia Pura doc:

screen shot 2014-10-04 at 3 36 04 pm

Also had the same issue with trying to split genrename within a chronstruct:

screen shot 2014-10-04 at 3 49 48 pm

brundin commented 9 years ago

I will look into this, Susan. -- MRB

SusanBrown commented 9 years ago

I forgot about just hitting return to break an element and meant to go back in and check whether that works, but haven't managed to.

On 2014-10-06 11:51 PM, brundin wrote:

I will look into this, Susan. -- MRB

— Reply to this email directly or view it on GitHub https://github.com/cwrc/CWRC-Schema/issues/89#issuecomment-58133086.

brundin commented 9 years ago

Might have to do with the limitations of trying to split an element when in author mode, as opposed to text mode. This forum thread (http://www.oxygenxml.com/forum/topic4813.html) seems to suggest that when in author mode, the refactoring > split element function operates on the lowest ancestor block element as defined in the associated CSS.

Here is the relevant section in the playwrights.css:

TEXTUALFEATURES P{display:block; margin-left:4%}

HEADING TITLE{DISPLAY:block; padding-top:1%;padding-bottom:1%; color:brown}

TEXTUALFEATURES HEADING[SUBTYPE="4"], TEXTSCOPE PRODUCTION HEADING[SUBTYPE="4"], TEXTSCOPE RECEPTION HEADING[SUBTYPE="4"] {display:block;color:black;font-weight:bold; padding-left:4%}

So, PRODUCTION, RECEPTION, and TEXTUALFEATURES are all block level elements, and thus can be split in author mode, but only P as a child of TEXTUALFEATURES (the first line) is defined as a block-level element, and thus only P within TEXTUALFEATURES can be split -- P within PRODUCTION and RECEPTION is an inline element.

Rather than modify the playwrights.css stylesheet to accommodate splitting elements when in author mode, maybe you could just quickly switch to text mode just when you need to split an element, and then quickly toggle back to author mode?

ilovan commented 9 years ago

I should be able to generally define P as a block in the css without changing the layout. I'll try it, notify you and Leslie, and we'll see how that works. What do you think, Susan? M.

On 2014-10-08, at 3:53 PM, brundin wrote:

Might have to do with the limitations of trying to split an element when in author mode, as opposed to text mode. This forum thread (http://www.oxygenxml.com/forum/topic4813.html) seems to suggest that when in author mode, the refactoring > split element function operates on the lowest ancestor block element as defined in the associated CSS.

Here is the relevant section in the playwrights.css:

TEXTUALFEATURES P{display:block; margin-left:4%}

HEADING TITLE{DISPLAY:block; padding-top:1%;padding-bottom:1%; color:brown}

TEXTUALFEATURES HEADING[SUBTYPE="4"], TEXTSCOPE PRODUCTION HEADING[SUBTYPE="4"], TEXTSCOPE RECEPTION HEADING[SUBTYPE="4"] {display:block;color:black;font-weight:bold; padding-left:4%}

So, PRODUCTION, RECEPTION, and TEXTUALFEATURES are all block level elements, and thus can be split in author mode, but only P as a child of TEXTUALFEATURES (the first line) is defined as a block-level element, and thus only P within TEXTUALFEATURES can be split -- P within PRODUCTION and RECEPTION is an inline element.

Rather than modify the playwrights.css stylesheet to accommodate splitting elements when in author mode, maybe you could just quickly switch to text mode just when you need to split an element, and then quickly toggle back to author mode?

— Reply to this email directly or view it on GitHub.

ilovan commented 5 years ago

no longer an issue in the newest versions of Oxygen (tested in Oxygen 21.0)