search

cwrc / CWRC-WriterBase

The base class from which to create a CWRC-Writer XML editor.
GNU General Public License v2.0
14 stars 3 forks source link

in-line notes and citations: if user right-clicks on any of the embedded entities without moving the cursor in place first, they get the right-click menu option to convert to an entity not to edit the existing (embeded) entity #132

Open ilovan opened 5 years ago

ilovan commented 5 years ago

Expected Behaviour

Right-clicking directly into the entity one wants to edit is likely to be desirable as a timesaving action for power users. Hence , the menu that action produces should be identical to when the user places the cursor in that area first and match the context of the text at that location (e.g. match the menu for an existing entity if one is present in that context.

Current Behaviour

When right-clicking WITHOUT selecting the text of the entity or placing the cursor inside the text of the entity first

feb-04-2019 13-53-23

When right-clicking AFTER selecting the text of the entity or placing the cursor inside the text of the entity first

feb-04-2019 14-03-05

Steps to Reproduce (for bugs)

Example doc: ilovan/Git-Writer-tests/in-line_note_Feb_2019_test2

ajmacdonald commented 5 years ago

@ilovan what OS and browser are you using in this case?

ilovan commented 5 years ago

Sorry:

MacOS High Sierra Chrome: 71.0.3578.98

ajmacdonald commented 5 years ago

https://github.com/cwrc/CWRC-WriterBase/commit/95f932cbe4548454a1ff0cc222a75f15050adda6

ilovan commented 5 years ago

works on dev-cwrc-writer; to test on prod