cwrc / CWRC-WriterBase

The base class from which to create a CWRC-Writer XML editor.
GNU General Public License v2.0
14 stars 3 forks source link

Moravian Lives schema docs - fix NERVE behaviour #233

Open ilovan opened 4 years ago

ilovan commented 4 years ago

Document: https://dev-cwrc-writer.cwrc.ca/?githubPath=TestGitWriterSchemaCSSchange&githubRepo=ilovan%2FGit-Writer-tests

Two Errors:

  1. NERVE identifies everything as person: image.png

  2. Once the NERVE-generated entities are all edited and accepted, they are all saved as RS tags. image.png

Moravian Lives has the same entity mappings as the schemas listed here: https://github.com/cwrc/CWRC-WriterBase/issues/120 Moravian Lives itself was set up by @lucaju : https://github.com/cwrc/CWRC-GitWriter/issues/65

May be related to how the handling is set up at: https://github.com/cwrc/CWRC-WriterBase/issues/194

ajmacdonald commented 4 years ago

Duplicate of https://github.com/cwrc/CWRC-WriterBase/issues/230 which is fixed, but not yet deployed

ilovan commented 4 years ago

not quite, I would say, @ajmacdonald , since The Moravian Lives schema has the same entity mappings as CWRC TEI lite )(and consequently should have NERVE assign the "proper" tags to identified named entities (i.e. persName, orgName, placeName, and NOT RS)

ajmacdonald commented 4 years ago

Ah, I had the wrong mappings for the Moravian schema. So it should be the CWRC Basic Schema mappings then.

ilovan commented 4 years ago

right - it should be identical to TEI Lite. @lucaju , I think you dealt with this - was it never pushed to dev: https://github.com/cwrc/CWRC-GitWriter/issues/65?

lucaju commented 4 years ago

It got pushed using teiLite as requested. Does teiLite === CWRC Basic Schema mappings? if not, perhaps it need to be changed?

ajmacdonald commented 4 years ago

It's confusing because the cwrc version's url includes tei lite: https://cwrc.ca/schemas/cwrc_tei_lite.rng But it is different from the tei's tei lite: https://www.tei-c.org/release/xml/tei/custom/schema/relaxng/tei_lite.rng

ilovan commented 4 years ago

NOte that TEI Lite (the default, TEI consortium TEI Lite schema) uses RS only, but the CWRC TEI Lite schema is a CWRC TEI customization that does support nominal entity tags (persName, placeName, orgName)

ajmacdonald commented 4 years ago

Right. My point is just that it can be easy to confuse the two.

ajmacdonald commented 4 years ago

https://github.com/cwrc/CWRC-GitWriter/commit/9b20fc21b7df2ffe461a60195108e636be496dc3