search

cwrc / CWRC-WriterBase

The base class from which to create a CWRC-Writer XML editor.
GNU General Public License v2.0
14 stars 3 forks source link

Translation ribbon button - "add responsibility" checkmark does not add the GitHub user id in the resp attribute #242

Open ilovan opened 4 years ago

ilovan commented 4 years ago

see https://github.com/cwrc/CWRC-WriterBase/issues/123 for discussion.

ilovan commented 4 years ago

not sure if this has something to do wiith the GitHub API, @lucaju , but I suspect it does, since it passed muster once.

ilovan commented 4 years ago

same on prod, so no connection to the API changes

ajmacdonald commented 4 years ago

I looked into it and you need to be using a schema that supports the resp attribute on a div tag, e.g. the EpiDoc schema.

ilovan commented 4 years ago

you're right - can we then show the checkmark option only when the resp attribute is available?

ajmacdonald commented 4 years ago

Yes

ajmacdonald commented 4 years ago

df2bdbe509a002f34691c196d984bd5e9037bcf6

ilovan commented 4 years ago

confirmed on dev-cwrc-writer