search

cwrc / CWRC-WriterBase

The base class from which to create a CWRC-Writer XML editor.
GNU General Public License v2.0
14 stars 3 forks source link

Right-click menu not working in Full-screen mode #263

Open SusanBrown opened 4 years ago

SusanBrown commented 4 years ago

The right-click menu is not working in Full-screen mode, either in CWRC or the Git-writer

If you right click on an entity or a tag in either the Tag menu or the editing panel you should get a popup menu

lucaju commented 4 years ago

I found this on Stackoverflow: https://stackoverflow.com/questions/18578244/displaying-elements-other-than-fullscreen-element-html5-fullscreen-api

The context menu is created as a sibling to the main CWRC-Writer container (div). When activating 'fullscreen", the browser assigns the maximum z-index [2147483647] to this container (nothing can get in from it), not even when we try to override the browser using the !important keyword. That is the reason the context menu doesn't 'pop' on fullscreen mode.

A possible solution is to move the context-menu DIV to inside the main CWRC-Writer DIV. I manually did this in the browser and it seems to work.

@ilovan, should I spend time with it, or should we wait until I get to redesign the context-menu?

SusanBrown commented 4 years ago

This is very encouraging, Luciano. Great to see it and that you think it is a solution. Presuming that the high priority tags here are up to date and still pending, I think that for now we should focus on the other high-priority issues, given that an update of CWRC-Writer needs to be fit in with the next update of CWRC which will be as soon as possible, and disable the full-screen button in the editor for that release. Once the other more urgent issues re: the schema problems have been dealt with, then spending some time on this if the update is not ready to go, makes sense to me. hope that's clear!

lucaju commented 4 years ago

Ok. I'm in the end tail to push code to that solves some problems with mapping schema. Already disabled full-screen button until we fix this issue. I will check the code on context-menu to see how much work I have to put on to solve this.

lucaju commented 4 years ago

Done: 23376abb0a47ba017e8e8117c51599a5e1a3ec95

lucaju commented 4 years ago

The context menu is slightly displaced from where the user click. This only happens in the integrated version.