search

cwrc / CWRC-WriterBase

The base class from which to create a CWRC-Writer XML editor.
GNU General Public License v2.0
14 stars 3 forks source link

Make content of scholarly notes and citations visible to to users in the read-only mode in a mouse-over pop-up #39

Closed ilovan closed 6 years ago

ilovan commented 6 years ago

@ajmacdonald , is this the right repo to put this issue in? I know that we only have the read-only mode in the CWRC-integrated Writer only, so I am thinking that you may want it placed in https://github.com/cwrc/Islandora-CWRC-Writer

ajmacdonald commented 6 years ago

@ilovan this is the right repo

ilovan commented 6 years ago

@ajmacdonald to look into whether it would be possible to make these mouse-over pop-ups display tag-determined formatting.

ajmacdonald commented 6 years ago

https://github.com/cwrc/CWRC-WriterBase/commit/ddcc34db162a84835c1e95c2ab9779482dc65cf0

ajmacdonald commented 6 years ago

In order to test this, we'll need a read only mode available somewhere. So I guess this is reliant on https://github.com/cwrc/Islandora-CWRC-Writer/issues/18

ilovan commented 6 years ago

I believe there is already a read-only mode available in the dev-06 version, as it is currently installed in dev-06. https://cwrc-dev-06.srv.ualberta.ca/islandora/object/islandora%3A3f8b2457-cc35-4441-b1a8-d584ef803214/view/default#islandora:3f8b2457-cc35-4441-b1a8-d584ef803214

Seems to be working fine to me. Can you push this code to the dev-06 version of the CWRC-Writer code and let me know when it's done to test it?

ajmacdonald commented 6 years ago

@ilovan yes I'll do that. FYI I can't easily selectively push updates so many other changes/fixes will also be deployed to dev-06.

ilovan commented 6 years ago

Would that deploy all the code before that particular fix? Can you please briefly review the pipelines between "review / QA 1" and "Deploy to dev-06" and move all the issues for which you are updating the code on dev-06 for to the "Review / QA final" pipeline? Thanks.

On Thu, Feb 15, 2018 at 11:11 AM, Andrew notifications@github.com wrote:

@ilovan https://github.com/ilovan yes I'll do that. FYI I can't easily selectively push updates so many other changes/fixes will also be deployed to dev-06.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cwrc/CWRC-WriterBase/issues/39#issuecomment-366013538, or mute the thread https://github.com/notifications/unsubscribe-auth/AGS1hgIjDsKs-0W10CfffOZPCBlVcG0Sks5tVHNRgaJpZM4Ryy_C .

-- Mihaela Ilovan

Project Manager Canadian Writing Research Collaboratory University of Alberta 4-20 Humanities Centre Edmonton, AB Canada T6G 2E5

780-966-4507 ilovan@ualberta.ca

ajmacdonald commented 6 years ago

@ilovan done

ilovan commented 6 years ago

thanks, will get on testing.

On Fri, Feb 16, 2018 at 12:36 PM, Andrew notifications@github.com wrote:

@ilovan https://github.com/ilovan done

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cwrc/CWRC-WriterBase/issues/39#issuecomment-366336917, or mute the thread https://github.com/notifications/unsubscribe-auth/AGS1hjYEWrSKky3d7lMy6Hz5j84RdyOeks5tVdijgaJpZM4Ryy_C .

-- Mihaela Ilovan

Project Manager Canadian Writing Research Collaboratory University of Alberta 4-20 Humanities Centre Edmonton, AB Canada T6G 2E5

780-966-4507 ilovan@ualberta.ca

ilovan commented 6 years ago

confirmed on Prod Git-Writer and dev-06 for notes; citations still display rather awkwardly, but I will create a separate issue for that