cwrc / DEPRECATED--CWRC-Dialogs

0 stars 0 forks source link

Blank listings in the entity lookup dialogs in Chrome (showing up fine in Firefox) #48

Closed ilovan closed 9 years ago

ilovan commented 9 years ago

Hi @lagoan and @mpm1 , Could you please try to fix this as soon as possible?

screen shot 2014-09-11 at 2 47 54 pm

lagoan commented 9 years ago

This does work on my side:

screen shot 2014-09-12 at 8 09 11 am

This means that this is likely a css issue. I can help figure it out.

@ilovan could you pass the url from where the screenshot was taken ?

Omar

+

On Thu, Sep 11, 2014 at 2:56 PM, Mihaela Ilovan notifications@github.com wrote:

Assigned #48 https://github.com/cwrc/CWRC-Dialogs/issues/48 to @lagoan https://github.com/lagoan.

— Reply to this email directly or view it on GitHub https://github.com/cwrc/CWRC-Dialogs/issues/48#event-164454489.

ilovan commented 9 years ago

I cleared my cashe and now I can't reproduce it either. Thanks for looking into it, but I guess it was a false alarm.

jefferya commented 9 years ago

reoccurring, see screenshot:

screen shot 2014-09-12 at 10 47 17 am

Possibly related to authentication.

Stand-alone dialogs can be observed opening a session: user 09/12/2014 - 10:39 Session opened for mark_test. ARC Mark Test

CWRC-Writer based dialogs have issues (my guess the issue occurs when not authorized to access Islandora).

lagoan commented 9 years ago

But the results are coming back, they are just not rendered properly.

@jefferya could you provide the URL to test it myself ?

lagoan commented 9 years ago

Got it from screenshot

http://apps.testing.cwrc.ca/editor/test/editor_dev.htm

lagoan commented 9 years ago

@jefferya Did the results format change ?

The name used to be retrieved from fgs_label_s

it now appears to be named object_label

if this is the case I can modify my code to reflect the changes of solr's output.

lagoan commented 9 years ago

@jefferya Would that be the changes in authentication access ?

jefferya commented 9 years ago

Hello Omar,

If not authenticated then only a sub-set of fields are returned in the JSON response. In other words, if authenticated then a 'full' set of fields are returned in the JSON response.

A good way to see the difference between authenticated and non-authenticated is to test the following URL in the following 2 senerios: (1) new browser instance with cache and cookies cleared (2) after log in to cwrc-dev-01.srv.ualberta.ca

http://cwrc-dev-01.srv.ualberta.ca/islandora/rest/v1/solr/(cwrc_entity_person_preferredForm_et:(omara)%20OR%20cwrc_entity_person_variantForm_et:(omara))?wt=json&limit=100&page=0&f[]=RELS_EXT_hasModel_uri_ms:info%5C:fedora%2Fcwrc%5C:person-entityCModel

You will see that (1) has as sub-set of fields compared to (2).

Also, nothing has changed with respect to the field names returned in the Solr JSON formatted response since June.

Cheers, ~jeff

On Fri, Sep 12, 2014 at 12:16 PM, Omar Rodriguez-Arenas < notifications@github.com> wrote:

@jefferya https://github.com/jefferya Would that be the changes in authentication access ?

— Reply to this email directly or view it on GitHub https://github.com/cwrc/CWRC-Dialogs/issues/48#issuecomment-55440947.

lagoan commented 9 years ago

So yes, based on your comments @mpm1 checked their code and in fact they are not authenticating before making the calls to the api. This in makes the results incomplete and that is why they are not receiving the names.

Using cD.initializeWithLogin with the appropriate credentials on their end will solve this issue.

Cheers,

ajmacdonald commented 9 years ago

Should be fixed now: https://github.com/cwrc/CWRC-Dialogs/commit/733eaeca4e5d1bd5e4595a2331761f7a671ff34a

jefferya commented 9 years ago

Hello Andrew,

The 'create' new entity fails due to authentication issues. Also, no error is reported to the user.

Not sure if I should start at new issue or append to this one or is a bug in the work from ARC. Thoughts?

Cheers, ~Jeff

On Wed, Oct 1, 2014 at 10:10 AM, Andrew notifications@github.com wrote:

Should be fixed now: 733eaec https://github.com/cwrc/CWRC-Dialogs/commit/733eaeca4e5d1bd5e4595a2331761f7a671ff34a

— Reply to this email directly or view it on GitHub https://github.com/cwrc/CWRC-Dialogs/issues/48#issuecomment-57491020.

ajmacdonald commented 9 years ago

I believe that issue is unrelated to this one. I would ask Mark McKellar about it. As per his instructions, I'm currently using cD.initializeWithCookieData(null) for authentication.

jefferya commented 9 years ago

Needs testing given recent back-end changes.