cwrc / DEPRECATED--CWRC-Dialogs

0 stars 0 forks source link

Editing: recordCreationDate value is lost during save. #49

Open jefferya opened 9 years ago

jefferya commented 9 years ago

Original

2014-11-27

After edit

ilovan commented 9 years ago

Status:

ilovan commented 9 years ago

based on discussion with @jefferya :

Also, Jeff, can you please reply to the last question in my previous comment?

brundin commented 9 years ago

recordCreationDate is intended to capture when the legacy authority record information or newly created entity record information was created; for the seed person, organization, and place entities, this is not known, and thus the existing ingested entities do not have a recordCreationDate element and value. We will attempt to hide this form element in the CWRC person entity dialog using CSS.

recordChangeDate is intended to capture the date the entity record information was last changed or modified. With respect to seed entities that have been ingested, only place entities have a recordChangeDate, as this information is/was readily available in the source GeoNames record. Regarding recordChangeDate being created when person entity is created: One could argue that upon record creation, this is also the last date of record modification, so a newly created entity using the dialog forms would have both a recordCreationDate and a recordChangeDate, and that date would be today's date.

MRB

On Mon, Feb 23, 2015 at 12:45 PM, Mihaela Ilovan notifications@github.com wrote:

based on discussion with @jefferya https://github.com/jefferya :

  • the record creation date field in the record info field set needs to be hidden from the user.

Also, Jeff, can you please reply to the last question in my previous comment?

— Reply to this email directly or view it on GitHub https://github.com/cwrc/CWRC-Dialogs/issues/49#issuecomment-75616787.

SusanBrown commented 9 years ago

I wonder if we shouldn’t create a recordCreationDate for seed/legacy entities. It is when we’re creating the record, and we can add a description item along the lines of “Batch ingest for incorporation into CWRC entity collection” or some such. What do you think?

On February 23, 2015 at 6:14:21 PM, brundin (notifications@github.com) wrote:

recordCreationDate is intended to capture when the legacy authority record information or newly created entity record information was created; for the seed person, organization, and place entities, this is not known, and thus the existing ingested entities do not have a recordCreationDate element and value. We will attempt to hide this form element in the CWRC person entity dialog using CSS.

recordChangeDate is intended to capture the date the entity record information was last changed or modified. With respect to seed entities that have been ingested, only place entities have a recordChangeDate, as this information is/was readily available in the source GeoNames record. Regarding recordChangeDate being created when person entity is created: One could argue that upon record creation, this is also the last date of record modification, so a newly created entity using the dialog forms would have both a recordCreationDate and a recordChangeDate, and that date would be today's date.

MRB

On Mon, Feb 23, 2015 at 12:45 PM, Mihaela Ilovan notifications@github.com wrote:

based on discussion with @jefferya https://github.com/jefferya :

  • the record creation date field in the record info field set needs to be hidden from the user.

Also, Jeff, can you please reply to the last question in my previous comment?

— Reply to this email directly or view it on GitHub https://github.com/cwrc/CWRC-Dialogs/issues/49#issuecomment-75616787.

— Reply to this email directly or view it on GitHub.

brundin commented 9 years ago

We could do that, Susan. There is a bit of tension/confusion in whether the child elements of recordInfo refer to administrative metadata about when the original legacy authority record was created, or whether they apply to the first transformation into our entity structure, or whether they apply or the entity records upon ingest into the repository, or whether there is a mixture of all three scenarios among the various child elements of recordInfo.

MRB

On Mon, Feb 23, 2015 at 4:40 PM, SusanBrown notifications@github.com wrote:

I wonder if we shouldn’t create a recordCreationDate for seed/legacy entities. It is when we’re creating the record, and we can add a description item along the lines of “Batch ingest for incorporation into CWRC entity collection” or some such. What do you think?

On February 23, 2015 at 6:14:21 PM, brundin (notifications@github.com) wrote:

recordCreationDate is intended to capture when the legacy authority record information or newly created entity record information was created; for the seed person, organization, and place entities, this is not known, and thus the existing ingested entities do not have a recordCreationDate element and value. We will attempt to hide this form element in the CWRC person entity dialog using CSS.

recordChangeDate is intended to capture the date the entity record information was last changed or modified. With respect to seed entities that have been ingested, only place entities have a recordChangeDate, as this information is/was readily available in the source GeoNames record. Regarding recordChangeDate being created when person entity is created: One could argue that upon record creation, this is also the last date of record modification, so a newly created entity using the dialog forms would have both a recordCreationDate and a recordChangeDate, and that date would be today's date.

MRB

On Mon, Feb 23, 2015 at 12:45 PM, Mihaela Ilovan <notifications@github.com

wrote:

based on discussion with @jefferya https://github.com/jefferya :

  • the record creation date field in the record info field set needs to be hidden from the user.

Also, Jeff, can you please reply to the last question in my previous comment?

— Reply to this email directly or view it on GitHub https://github.com/cwrc/CWRC-Dialogs/issues/49#issuecomment-75616787.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/cwrc/CWRC-Dialogs/issues/49#issuecomment-75662682.

ghost commented 9 years ago

What do you think would be best? I was trying to get around the notion of having to customize CSS since it seemed to me reasonable to indicate when the CWRC record was created. It’s not like any of these entities really pre-existed CWRC in this form, so it seemed to me reasonable. Do you think it’s unwise?

On February 23, 2015 at 7:41:20 PM, brundin (notifications@github.com) wrote:

We could do that, Susan. There is a bit of tension/confusion in whether the child elements of recordInfo refer to administrative metadata about when the original legacy authority record was created, or whether they apply to the first transformation into our entity structure, or whether they apply or the entity records upon ingest into the repository, or whether there is a mixture of all three scenarios among the various child elements of recordInfo.

MRB

On Mon, Feb 23, 2015 at 4:40 PM, SusanBrown notifications@github.com wrote:

I wonder if we shouldn’t create a recordCreationDate for seed/legacy entities. It is when we’re creating the record, and we can add a description item along the lines of “Batch ingest for incorporation into CWRC entity collection” or some such. What do you think?

On February 23, 2015 at 6:14:21 PM, brundin (notifications@github.com) wrote:

recordCreationDate is intended to capture when the legacy authority record information or newly created entity record information was created; for the seed person, organization, and place entities, this is not known, and thus the existing ingested entities do not have a recordCreationDate element and value. We will attempt to hide this form element in the CWRC person entity dialog using CSS.

recordChangeDate is intended to capture the date the entity record information was last changed or modified. With respect to seed entities that have been ingested, only place entities have a recordChangeDate, as this information is/was readily available in the source GeoNames record. Regarding recordChangeDate being created when person entity is created: One could argue that upon record creation, this is also the last date of record modification, so a newly created entity using the dialog forms would have both a recordCreationDate and a recordChangeDate, and that date would be today's date.

MRB

On Mon, Feb 23, 2015 at 12:45 PM, Mihaela Ilovan <notifications@github.com

wrote:

based on discussion with @jefferya https://github.com/jefferya :

  • the record creation date field in the record info field set needs to be hidden from the user.

Also, Jeff, can you please reply to the last question in my previous comment?

— Reply to this email directly or view it on GitHub https://github.com/cwrc/CWRC-Dialogs/issues/49#issuecomment-75616787.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/cwrc/CWRC-Dialogs/issues/49#issuecomment-75662682.

— Reply to this email directly or view it on GitHub.

ilovan commented 9 years ago

I just tested the current behaviour:

When creating a new entity, the "Record creation date" label appears on the last line in the form, which might be somewhat confusing for the users. Can it be removed like the field was?

When editing an existing entity, the "Record creation date" label, together with the field it precedes show up, with the field populated with the record creation date. The content of the field can't be modified, but the field can be removed by pressing the "-" button to its right. This removes the record creation date tag from the XML, which shouldn't be allowed.

image

brundin commented 9 years ago

As always, very thorough testing, Mihaela!

On Fri, Feb 27, 2015 at 1:08 PM, Mihaela Ilovan notifications@github.com wrote:

I just tested the current behaviour:

When creating a new entity, the "Record creation date" label appears on the last line in the form, which might be somewhat confusing for the users. Can it be removed like the field was?

When editing an existing entity, the "Record creation date" label, together with the field it precedes show up, with the field populated with the record creation date. The content of the field can't be modified, but the field can be removed by pressing the "-" button to its right. This removes the record creation date tag from the XML, which shouldn't be allowed.

[image: image] https://cloud.githubusercontent.com/assets/6600070/6420127/99f2602a-be80-11e4-829a-4851ac7c3daa.png

— Reply to this email directly or view it on GitHub https://github.com/cwrc/CWRC-Dialogs/issues/49#issuecomment-76462905.

jefferya commented 9 years ago

I've used CSS to hide. It should still maintain the form value and thus prevent the creation date from disappearing from the XML serialization stored within Fedora after an edit.