cwrc / DEPRECATED--CWRC-Dialogs

0 stars 0 forks source link

Editing: XML input and output don't match if no changes made to the dialogue contents #52

Closed jefferya closed 9 years ago

jefferya commented 9 years ago

The gist of the bug. During an edit operation, where no changes are done to the dialog values, the dialog does not yield the same XML output as was originally loaded into the dialog. A specific example. I.E. clinking 'edit' then 'ok' without making changes should yield no changes to the XML but there is a bug.

For example, a person originally with 2 separate variant names (not 2 separate name parts) will end up with only 1 variant element containing 2 nameparts after the edit operation. The bug is captured in the attached 2 screenshots. The screenshot at 10.11.18 shows the incoming XML at the lower part of the image. Notice the 2 variant elements on the last line of the XML. The second screenshot at 10.12.32 shows the resulting XML after the 'save' in edit mode. Notice there is now only 1 variant element. This also happens with other entities including titles.

Gut feeling - this may be related to issue #40.

screen shot 2014-11-27 at 10 12 32 2 screen shot 2014-11-27 at 10 11 18 1