search

cwrc / DEPRECATED--CWRC-Dialogs

0 stars 0 forks source link

URI added as the “ref” attribute value by CWRC-Writer is wrong #71

Open jefferya opened 9 years ago

jefferya commented 9 years ago

URI added as the “ref” attribute value by CWRC-Writer is wrong and in some cases (e.g. Google GeoCode) useless. Value is passed from Entity Dialogues.

2-3 days to craft something that will somewhat work for the 2 main cases (i.e. progress the work forward but work will remain on other parts of CWRC URIs handling infrastructure)

= CWRC entities = Google Geocode == ref google API key and querying e-mail

jefferya commented 9 years ago

Logic improved, will require change within the CWRC-Writer once dialog code is pulled into dev. The change is on line

https://github.com/cwrc/CWRC-Writer/blob/development/src/js/dialogs/cwrcDialogBridge.js#L80

The dialog code should now return "uri" which should alleviate the need for this code block as the logic is handled within the dialog code.

jefferya commented 9 years ago

The fix is within pull request https://github.com/cwrc/CWRC-Writer/pull/323

Needs to be tested within Islandora.