search

cwrc / DEPRECATED-CWRC-Writer

The Canadian Writing Research Collaboratory (CWRC) is developing an in-browser text markup editor (CWRCWriter) for use by collaborative scholarly editing projects.
http://www.cwrc.ca/projects/infrastructure-projects/technical-projects/cwrc-writer/
GNU General Public License v2.0
24 stars 17 forks source link

Entity URIs - review code and behaviour. #368

Closed ilovan closed 8 years ago

ilovan commented 8 years ago

CWRC entity lookup and creation doesn't work with the stand-alone version of the CWRC-Writer, but that in itself is not necessarily an issue since we made these configurable from within the dgi-built integration module.

I noticed, however, that in the integrated version of CWRC-Writer, the CWRC entity URIs listed in the entities tab and the ones users can see in the disambiguation ("info") bubble in the entity lookup dialog are prefixed by "null" instead of "http://commons.cwrc.ca/" as they should:

image

I suspect that this is more of an integration module issue, but before I contact dgi, could you please check that the problem is not something that crept in when you were making the dialogs easier to integrate with CWRC Writer or when you were updating the TinyMC?

Two starting points that we can think of:

ajmacdonald commented 8 years ago

I'm seemingly unable to access the integrated version with my previous credentials. Can you email me new ones?

ilovan commented 8 years ago

Just did, let me know if you're still having issues.

ajmacdonald commented 8 years ago

You're correct, it is an integration issue. This property is missing from dgi's config: https://github.com/cwrc/CWRC-Writer/blob/development/src/js/writerConfig.js#L5

jordandukart commented 8 years ago

Hey @ilovan,

Should the repositoryBaseObjectUrl setting be set as the prefixed part of the URL or the fully resolvable path? For example, http://commons.cwrc.ca/entitypid vs http://commons.cwrc.ca/islandora/object/entitypid?

ilovan commented 8 years ago

Hi @jordandukart ,

We would like to go with http://commons.cwrc.ca/entitypid.

We also need to keep in mind that we are in process of adopting ssl on beta. Is this going to affect the behaviour when clicking on an http: link? @ajmacdonald , if you could join this conversation, that would be great.

ajmacdonald commented 8 years ago

I'm not an expert but if you have SSL I think you need to specify https in the link in order to take advantage of it.

ilovan commented 8 years ago

we're still testing SSL, so for now, let's go with http://commons.cwrc.ca/entitypid.