Note popups not working in view mode or when doc is saved and reopened in edit mode in embedded CWRC-Writer

[SusanBrown]

@jefferya I was just testing this. Hopefully I have a doc that uses the wrong schema objects: http://beta.cwrc.ca/islandora/object/islandora%3A1a806fe6-f1e4-45ae-bcca-fe03ae4ee2d1/edit-cwrc#islandora:1a806fe6-f1e4-45ae-bcca-fe03ae4ee2d1 Could you please point me at a doc you are confident is right?

[jefferya]

@SusanBrown Can you elaborate on problems with the note popups? How are they suppose to work in "view" mode? How are they suppose to work in "edit" mode?

I was only aware of the problem in "edit" mode where creating new notes or editing those new notes was not working. I can do both in the following doc. http://beta.cwrc.ca/islandora/object/islandora%3A73900c35-bd0d-4690-b911-44cb12b874eb

Note: After each CWRC-Writer change the browser cache needs to be deleted otherwise the browser will use an old version of the javascript instead of the new version.

[SusanBrown]

Ideally they should work as popups in view mode as well.

Maybe I’m blind and didn’t see that they we still rendering in square brackets in the main reading window, —this is a big improvement over not being able to read the contents of a note at all. Perhaps it wasn’t working before until I cleared my cache and retested. At any rate this is adequate for the time being.

A popup of some kind (ideally more like a simple popup than a mini-CWRC-writer, and one that would disappear if you clicked elsewhere, scrolled, etc.) would be the preferred functionality.

Andrew, can you imagine being able to do this relatively quickly within a CSS, to have it render the contents of the tag within a dialog? We’ve had this request from other projects than Orlando or I wouldn’t make it a priority now.

On Oct 1, 2016, at 9:21 PM, Jeffery Antoniuk notifications@github.com<mailto:notifications@github.com> wrote:

@SusanBrownhttps://github.com/SusanBrown Can you elaborate on problems with the note popups? How are they suppose to work in "view" mode? How are they suppose to work in "edit" mode?

I was only aware of the problem in "edit" mode where creating new notes or editing those new notes was not working. I can do both in the following doc. http://beta.cwrc.ca/islandora/object/islandora%3A73900c35-bd0d-4690-b911-44cb12b874eb

Note: After each CWRC-Writer change the browser cache needs to be deleted otherwise the browser will use an old version of the javascript instead of the new version.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/cwrc/CWRC-Writer/issues/446#issuecomment-250947800, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAhUoA5u1kZ3zbbQAXQHdtDkT03wu2lVks5qvwcMgaJpZM4KLpPV.

[ajmacdonald]

I can confirm that notes in view mode aren't working standalone or embedded versions.

While a simple popup is possible, the problem I see with that is that the schema CSS won't be applied to the note contents being shown in that popup.

[ajmacdonald]

Please test