search

cwrc / DEPRECATED-CWRC-Writer

The Canadian Writing Research Collaboratory (CWRC) is developing an in-browser text markup editor (CWRCWriter) for use by collaborative scholarly editing projects.
http://www.cwrc.ca/projects/infrastructure-projects/technical-projects/cwrc-writer/
GNU General Public License v2.0
24 stars 17 forks source link

Ctrl-F Search doesn't work within reading panel of CWRC-Reader #460

Closed SusanBrown closed 5 years ago

SusanBrown commented 7 years ago

@ajmacdonald I can't test this on the standalone because it doesn't include the reader. Can you determine whether this can/should be fixed on your end?

Searching within the editing panel works in both.

ajmacdonald commented 7 years ago

Read-only mode tries to block any keys inputted into the editing/reading pane. You can get search working but you have to shift focus (by clicking) outside of that pane, and then use ctrl+f.

ilovan commented 6 years ago

Confirmed in the old CWRC-Reader. Waiting for an integrated version of the new Reader to test; My guess is that this could be mitigated by a popup instructing the user to click outside the text area.

ilovan commented 6 years ago

Still an issue in the new integrated version

ilovan commented 6 years ago

@ajmacdonald , can we detect when the user wants to use the browser search and warn them whit a popup to click outside the text area?

ajmacdonald commented 6 years ago

@ilovan yes that should be doable

ilovan commented 6 years ago

great, let's try to do that then (i.e not right now, when we get to this ticket)

ajmacdonald commented 6 years ago

https://github.com/cwrc/CWRC-WriterBase/commit/3ae89a924199b39a34d367d0266885a1920c5867

ilovan commented 6 years ago

working now

ilovan commented 5 years ago

confirmed on prod cwrc