command panel scrolling

[SusanBrown]

need to be able to scroll entire panel: can't get to the edges

[cmiya]

Related to #21 Discard Bin Obscured By Command Tab.

[wolfmaul]

I've had a chance to look at this issue and experiment with some options. I think what might make the most sense is to divide the screen at the command box (i.e. two framed areas) and centre the graph in the left frame. This would leave the discard area in the bottom right, but it would mean it would never be obscured by the command 'frame' area. The command frame would still need to scroll to accommodate longer text, but the implementation would be easier and more consistent.

Currently the tabs drop down into a fixed box height, which has its down sides for how it works with more extreme window sizes: e.g. for very large screens the box is overly restrictive (short), and for small screens it is overly large and obscures the discard bin). The frame layout also makes it relatively easy to add functionality, letting the user to adjust the width of the framed areas. In this way command box could be made wider to better display the Edges-of-the-Selected-Notes section. For deep ontologies it really helps to be able to spread the display out to better see relationships (and make it possible to see more without scrolling).

[SusanBrown]

All these ideas sound great. Let's do it!

[smurp]

I believe this issue and its proposed solution ought to replace issues #61 and #21

[antimony27]

@smurp Great - I closed #61 and #21 and will leave this issue open for you and @wolfmaul to work away on.

[smurp]

I'm looking at the current behaviour on http://alpha.huviz.dev.nooron.com/ and noticing that the "predicate picker" is requiring scrolling instead of occupying as much vertical space as it needs. This is occurring in a tall window.

[smurp]

This situation is looking really good now, @wolfmaul . One niggle. Some lost functionality is that when one clicks the tab which is currently focused (say you're already on "Commands" and you click it again) then it used to collapse the whole panel on the right so just the tabs were showing. What is happening right now is that the contents disappear (GOOD) but the panel remains (BAD) so the graph no longer has the whole window to display itself in. Clear?

[SusanBrown]

This problem persists, I'm afraid. I find today that on my laptop (macbook) with the window as large as it can be without going into full screen mode, I can't get to the bottom two options on the command panel.

[wolfmaul]

Fixed the scrolling issue on the control panel.

@smurp -- The issue around the tabs collapsing the whole panel is a trickier. In order to make the scrolling work in that side panel, I made some changes to the way it works. As seen, this conflicts somewhat with the functioning with the collapsing tabs. This is not an obvious fix, and it could take a bit of fiddly time to sort out how things will play nice together. It's a little tricky because jQuery is doing the work on the tab functionality. I'm a little reluctant to spend the time, when I can 'fix' the problem by turning off the feature in 30sec. The functionality of the tab collapse is a duplication of the added collapse button so it isn't really critical to keep. There is an argument to be made that the duplication of functionality isn't the best anyway. I can of course proceed with finding a solution, but I thought I would first check in to see how badly we want to recover that functioning before going further.

[SusanBrown]

I agree with Wolf that this feature could just be turned off. The double >> to the left of the intro tab is both clearer and more evident and I don’t thin we need to fix this since it would be fiddly.

On Dec 14, 2018, at 5:57 PM, Wolf Maul notifications@github.com<mailto:notifications@github.com> wrote:

Fixed the scrolling issue on the control panel.

@smurphttps://github.com/smurp -- The issue around the tabs collapsing the whole panel is a trickier. In order to make the scrolling work in that side panel, I made some changes to the way it works. As seen, this conflicts somewhat with the functioning with the collapsing tabs. This is not an obvious fix, and it could take a bit of fiddly time to sort out how things will play nice together. It's a little tricky because jQuery is doing the work on the tab functionality. I'm a little reluctant to spend the time, when I can 'fix' the problem by turning off the feature in 30sec. The functionality of the tab collapse is a duplication of the added collapse button so it isn't really critical to keep. There is an argument to be made that the duplication of functionality isn't the best anyway. I can of course proceed with finding a solution, but I thought I would first check in to see how badly we want to recover that functioning before going further.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/cwrc/HuViz/issues/104#issuecomment-447386026, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAhUoM300MbpaI0MYAq30v66GGOhgFcRks5u49iTgaJpZM4N2NDa.