cwrc / HuViz

LOD visualization tool for humanities datasets
8 stars 1 forks source link

update the Dataset and Ontology pickers immediately upon change of Script picked #263

Open smurp opened 5 years ago

smurp commented 5 years ago

Expected Behaviour

Picking a script should immediate set the Ontology and Dataset, leaving open the possibility of user change but permitting actual data loading upon the first press of Load, as happens with all other pickers.

Current Behaviour

There is currently a need for the Load button to be pressed twice by the user after selection of a script: once to update the dataset and ontology and a second time to actually proceed with data loading.

Issues

smurp commented 5 years ago

https://github.com/smurp/huviz/commit/2c6045d6a06176edd1cb701a3103f36c04d6b3c7

smurp commented 5 years ago

The reload button seems flakey after this but I was unaware of it being flakey before.

smurp commented 5 years ago

http://alpha.huviz.dev.nooron.com/#load+/data/abdyma.nq+with+https://cwrc.ca/ontologies/OrlandoOntology-2015-11-16.ttl

... and then running the command Activate All. and then saving that script produces a script which works both on alpha and in dev. Earlier I was seeing some misbehaviour in development which might have been a consequence of the particular data I had in my various PickOrProvide menus.

smurp commented 5 years ago

Gack, changing the Script loader selection does still misbehave.

antimony27 commented 5 years ago

I'm getting the correct onto and dataset when I select a script I have run in the past. I'm not clear, however, on what your second tickbox (selecting one script and then changing the selection to another LOADs the new dataset and onto immediately) means. Can you explain @smurp ?