cwrc / HuViz

LOD visualization tool for humanities datasets
8 stars 1 forks source link

refactor huviz ejs into stanzas #370

Open smurp opened 4 years ago

smurp commented 4 years ago

The commit https://github.com/smurp/huviz/commit/b01e11172a5759fe07e43dcd79901b45bf902d01 establishes some stanzas which should be used by the rest of the huviz ejs templates to perform the loading of .css and .js resources.

The point of this development is the simplification of the deployment of HuViz in other environments and reviving of the test suite #216

smurp commented 4 years ago

Extra bonus points for enhancing the stanzas so they restore support for offline development by using local copies of the dependencies: fontawesome, jquery, jquery-ui, d3, etc. See notps.is_local in views/huvis.html.ejs for how this works. This means that those libraries should be converted to devDependencies in package.json

smurp commented 4 years ago

@wolfmaul A remaining detail is the font color of the selected tab when using CDN.

smurp commented 4 years ago

Another step with this item is writing up some documentation on the README about how to embed HuViz in something, using these templates.

smurp commented 4 years ago

Note that this is a step in the direction of #216 Revive the test suite which can now make use of these new templates.