search

cwrc / HuViz

LOD visualization tool for humanities datasets
8 stars 1 forks source link

expose Matched set and continuous labelling of matching nodes #372

Open smurp opened 4 years ago

smurp commented 4 years ago

I was tightening up some code which seemed to be a performance issue and realized that the matching: regex (whatever the user has typed in the matching: box) was being tested against node names on every tick. While optimizing this some good things fell out:

  1. now, typing in the matching: box adds the matching nodes to the Matched set continuously, so the count appears in the Sets picker
  2. all the Matched nodes have their labels displayed, whether on the shelf or the graph

So the experience is quite lovely... typing in the matching: box labels the nodes found and updates the count in the Matched set.

image

Sorry this didn't go through prioritization: it was a performance issue I noticed and this was a quick fix -- with other benefits.

smurp commented 4 years ago

This code was rolled back along with the boxNG work. For eventual restoration.