Ability to select language of labels

SusanBrown commented 7 years ago

I know we've flagged this previously but I can't find an issue for it. @smurp this is becoming more of a problem as more of our ontology is translated: it draws on French and English labels indiscriminately.

[x] make a language path setting
[x] make node labels respect language path
[x] make class picker respect language path
[ ] make edge picker respect language path
[x] support wildcard ANY, NOLANG and ALL keywords
[x] provide error message and docs
[ ] make the setting less fragile when user submits a syntax error (handle update and change differently)
[x] support labels (which are in human languages) rather than ids (which are not) on boxes in the pickers
[x] add multiple language variants on the TreeCtrl (ie Taxon or Predicate) instances
[x] support alteration of labels on the boxes in the pickers
[x] support reordering (sorting) of the boxes in the pickers to reflect language change
[x] reorder class_picker
[ ] reorder predicate_picker
[x] support triggering of recoloring of the pickers when reordering happens
[x] restore expander/collapser, currently lost when language changes
[x] fix anything label disappearing on language change
[x] update_labels_on_pickers before resort_recursively
[x] recolor nodes after resorting classes
[ ] recolor edges after resorting predicates
[ ] ensure names are propagated to predicate picker
[ ] add setting for name propagation to predicate picker

smurp commented 7 years ago

Thanks Susan, understood.

On Fri, May 12, 2017 at 3:12 PM, SusanBrown notifications@github.com wrote:

I know we've flagged this previously but I can't find an issue for it. @smurp https://github.com/smurp this is becoming more of a problem as more of our ontology is translated: it draws on French and English labels indiscriminately.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cwrc/HuViz/issues/84, or mute the thread https://github.com/notifications/unsubscribe-auth/AAvP58BJxHLfVmqmCjy0Du0sNvwoSPSSks5r5MsmgaJpZM4NZykO .

-- Shawn Murphy smurp@smurp.com (780) 903-2428 http://www.smurp.com

smurp commented 7 years ago

Added language path setting and made node labels respect it. Also deployed to alpha.

https://github.com/smurp/huviz/commit/38e2f32178286abb07693e5856ec659191fad395

smurp commented 7 years ago

deployed ANY, NOLANG, ALL, docs and error message to alpha

SusanBrown commented 7 years ago

Working great! Love the popup explanation if one puts in something incorrect.

Can I just suggest glossing the examples?

fr:en means show French labels when available and then English en:ANY:NOLANG means show English labels first, then any other labels ALL shows all language labels at once; best used alone

[that is if I have it right for ALL -- see new issue]

SusanBrown commented 7 years ago

Language ALL:

I am not sure exactly what it does because I don't see the French label for acrostic (acrostiche) when I use the ALL setting, even though it is showing up when I designed fr, and a search on "like acrostiche" does nothing

smurp commented 7 years ago

It shows ALL the different "value"@lang pairs, comma delimited. If there is a NOLANG version it just tacks that on at the end, in quotes. I see things like:

"jewish"@en, "juif"@fr
"Context"@en, "Contexte"@fr
"dog"@en, "chien"@fr, "pooch"   <--- for example, where 'pooch' is NOLANG

Again, a NOLANG version is when there is no language specified for a label.

I am currently seeing

"acrostic"@en, "acrostiche"@fr

using "HuVizSHARP2017"/"CWRC Ontology sans Genres" and the command

Label ALL like 'acrostic' .

smurp commented 7 years ago

The bug you are reporting DID exist but I think that version was only running on alpha for a couple of hours yesterday. Any dataset recommendation so I can reproduce this?

ghost commented 7 years ago

I produced it today, I’m afraid to say. I’m not 110% sure what dataset (sorry) but I think am pretty sure it was https://github.com/cwrc/ontology/blob/master/demoData/HuVizSHARP2017.ttl no ontology loaded

On Jun 15, 2017, at 4:40 PM, Shawn Murphy notifications@github.com wrote:

The bug you are reporting DID exist but I think that version was only running on alpha for a couple of hours yesterday. Any dataset recommendation so I can reproduce this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cwrc/HuViz/issues/84#issuecomment-308859642, or mute the thread https://github.com/notifications/unsubscribe-auth/AA1s9d3Mw9BKIHYNnZ3P6_R9PhOLPbO6ks5sEZa_gaJpZM4NZykO.

smurp commented 7 years ago

Maybe I'm wrong about when the bug-fixed version was deployed?!? I would be surprised if that could be reproduced. :-)

smurp commented 7 years ago

Oh yeah, I remembered to include the watermark in the screenshot to document the code version.

How about if I up the priority of including dataset and ontology identifiers in the watermark.

SusanBrown commented 7 years ago

Sounds good.

On Jun 15, 2017, at 9:41 PM, Shawn Murphy notifications@github.com<mailto:notifications@github.com> wrote:

[acrostic_all]https://user-images.githubusercontent.com/774119/27208317-d88dba5a-51f9-11e7-96bc-6a8ff9fb5d92.png

Oh yeah, I remembered to include the watermark in the screenshot to document the code version.

How about if I up the priority of including dataset and ontology identifiers in the watermark.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/cwrc/HuViz/issues/84#issuecomment-308909791, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAhUoEwOlxmNqbBswXI4gqLJXu3Z6z_Qks5sEd06gaJpZM4NZykO.

cmiya commented 6 years ago

I noticed that make class picker/edge picker respect language path are still unchecked in the task list in the initial issue description. How are the language settings working? Are there still bugs? Or can we close this issue?

smurp commented 6 years ago

Getting the pickers to respect the language path has in fact not been done yet. These require the following changes to the TreePicker code:

support labels (which are in human languages) rather than ids (which are not) on boxes in the pickers
add multiple language variants on the TreeCtrl (ie Taxon or Predicate) instances
support alteration of labels on the boxes in the pickers
support reordering (sorting) of the boxes in the pickers to reflect language change
reorder class_picker
reorder predicate_picker
support triggering of recoloring of the pickers when reordering happens

.... and that is why it hasn't happened yet. :-)

PS these steps have been moved to the main issue description

smurp commented 5 years ago

https://github.com/smurp/huviz/commit/8d946b847475a4a470f3975ebba8d

smurp commented 5 years ago

fixed anything label disappearing on language change with https://github.com/smurp/huviz/commit/f833a034c57df42f54b62b116c4eb5cf260c4a34

cwrc / HuViz

Ability to select language of labels #84