search

cwrc / Islandora-CWRC-Writer

Islandora wrapper for the CWRC-Writer.
https://github.com/cwrc/CWRC-Writer
GNU General Public License v3.0
0 stars 3 forks source link

Remove stale entity code to avoid confusion #31

Open jefferya opened 6 years ago

jefferya commented 6 years ago

Two modules contain code to edit/search entities. The stale, deprecated code should be removed with any useful features ported to the new (e.g., error handling). Note: this could be done in conjuction with the TEI entities work.

Review: https://github.com/cwrc/cwrc_entities

Depreciate (and pull out useful bits): https://github.com/cwrc/Islandora-CWRC-Writer/blob/master/includes/entity.inc

SusanBrown commented 6 years ago

@ajmacdonald Is this straight-forward and if so can we assign this to you?

ajmacdonald commented 6 years ago

@SusanBrown this code is in PHP which isn't something I'm very familiar with

ilovan commented 6 years ago

@ajmacdonald , could you do it though if you checked in with @jefferya along the way?

ajmacdonald commented 6 years ago

@ilovan as a last resort I could try it but I would warn that this is outside of my expertise in two areas: Drupal and PHP

SusanBrown commented 6 years ago

@nikathone We think you could undertake this. Please consult as needed.